fix: infinite loop error replace_type_placeholder (#223)

* Add global flag * Add changeset
sveltejs · Sep 13, 2023 · a1f2c5b · a1f2c5b
1 parent 2952ea3
commit a1f2c5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/healthy-cars-breathe.md b/.changeset/healthy-cars-breathe.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/site-kit': patch
+---
+
+fix: infinite loop error replace_type_placeholder
diff --git a/packages/site-kit/src/lib/markdown/renderer.js b/packages/site-kit/src/lib/markdown/renderer.js
@@ -519,7 +519,7 @@ export async function replace_export_type_placeholders(content, modules) {
 		EXPANDED_TYPES: /> EXPANDED_TYPES: (.+?)#(.+)$/gm,
 		TYPES: /> TYPES: (.+?)(?:#(.+))?$/gm,
 		EXPORT_SNIPPET: /> EXPORT_SNIPPET: (.+?)#(.+)?$/gm,
-		MODULES: /> MODULES/,
+		MODULES: /> MODULES/g, //! /g is VERY IMPORTANT, OR WILL CAUSE INFINITE LOOP
 		EXPORTS: /> EXPORTS: (.+)/
 	};
 
@@ -531,7 +531,6 @@ export async function replace_export_type_placeholders(content, modules) {
 			.replace(REGEXES.MODULES, '')
 			.replace(REGEXES.EXPORTS, '');
 	}
-
 	content = await async_replace(content, REGEXES.EXPANDED_TYPES, async ([_, name, id]) => {
 		const module = modules.find((module) => module.name === name);
 		if (!module) throw new Error(`Could not find module ${name}`);