Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect Encoding Object while building requests #9105

Merged
merged 3 commits into from
Aug 1, 2023
Merged

feat: respect Encoding Object while building requests #9105

merged 3 commits into from
Aug 1, 2023
+321 −283

Conversation

char0n
Copy link
Member

@char0n char0n commented Aug 1, 2023 •
edited
Loading

This change fixes both:

  1. making multipart/form-data requests with content-type header for every individual boundary
  2. generating correct CURL command for multipart/form-data request, allowing specifying content-type header for every individual boundary

Refs #4826
Refs #5356

multipart/form-data boundaries now containing Content-Type headers:

image

CURL command correctly generated by assigning additional type=:

image

@char0n
feat: respect Encoding Object while building requests
33207f7 
This change fixes both:

1. making multipart/form-data requests with content-type
   header for every individual boundary
2. generating correct CURL command for multipart/form-data
   request, allowing specifying content-type header for every
   individual boundary

Refs #4826
Refs #5356
@char0n char0n self-assigned this Aug 1, 2023
char0n
char0n commented Aug 1, 2023
View reviewed changes
src/core/window.js Outdated Show resolved Hide resolved
char0n
char0n commented Aug 1, 2023
View reviewed changes
test/unit/core/curlify.js Outdated Show resolved Hide resolved
This was referenced Aug 1, 2023
Closed
Closed
Closed
@char0n char0n merged commit b281473 into master Aug 1, 2023
6 checks passed
@char0n char0n deleted the char0n/4826 branch August 17, 2023 13:08
@ITman1 ITman1 mentioned this pull request Aug 18, 2023
Closed
@fethiyildiz fethiyildiz mentioned this pull request Sep 18, 2023
Closed
@LaFrimousse
Copy link

Hi all.

Unfortunately, this fix does not solve #5356 .
Please see my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@char0n char0n

Labels
type: bug version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@char0n @LaFrimousse