Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help text around positional arguments #81

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Fix help text around positional arguments #81

merged 3 commits into from
Mar 28, 2022

Commits on Mar 28, 2022

  1. Add unit test to verify positionals are required 

    Ensure that under the "positional arguments" section in the help text,
positional arguments are noted as "required".
    @ShaneEverittM
    ShaneEverittM committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a375aa5 View commit details
    Browse the repository at this point in the history

  2. Add utility to check if an argument is positional 

    Add an analogous but opposite function to "is_option_arg" to improve
readability.
    @ShaneEverittM
    ShaneEverittM committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    485f0b9 View commit details
    Browse the repository at this point in the history

  3. Make positional arguments implicitly required 

    When computing the help text for required or defaults, include
positional arguments in those that are required.
    @ShaneEverittM
    ShaneEverittM committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2771a8e View commit details
    Browse the repository at this point in the history