combustion #1432
Merged
combustion #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
byorgey
reviewed
Aug 19, 2023
kostmo
force-pushed
the
feature/combustion
branch
from
86961ab
to
f741e48
Compare
kostmo
force-pushed
the
feature/combustion
branch
from
f741e48
to
b8fadf7
Compare
byorgey
approved these changes
Aug 20, 2023
src/Swarm/Game/Step.hs
Outdated
| (loc, me) <- lookInDirection d | ||
| -- Ensure there is an entity here. | ||
| e <- | ||
| me `isJustOrFail` ["There is nothing here to", verb <> "."] |
There was a problem hiding this comment.
Don't we have code very similar to this in other places? Is there an opportunity to factor out some repeated code?
Closed
kostmo
force-pushed
the
feature/combustion
branch
from
1b0c160
to
80f5e22
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1355
Demo