Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unification-fd with a custom implementation of unification #1802

Merged
merged 50 commits into from
Apr 27, 2024
Merged

Replace unification-fd with a custom implementation of unification #1802

merged 50 commits into from
Apr 27, 2024

Commits on Jan 17, 2024

  1. some initial explorations into custom unification code (towards #1661)

    @byorgey
    byorgey committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ea1d6ef View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. WIP: substitution

    @byorgey
    byorgey committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    35c94fb View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'main' into refactor/custom-unification

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9cff7ed View commit details
    Browse the repository at this point in the history

  2. fix .cabal

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2305185 View commit details
    Browse the repository at this point in the history

  3. fix warning

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5d321da View commit details
    Browse the repository at this point in the history

  4. better names in Subst

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3e9b7b8 View commit details
    Browse the repository at this point in the history

  5. WIP: start ripping out unification-fd 

    Replace with modern standard implementations of `Free` and `Fix`.
    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    61f5b14 View commit details
    Browse the repository at this point in the history

  6. use wrapFix in preference to directly using the Fix constructor

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f258ff4 View commit details
    Browse the repository at this point in the history

  7. fix a few warnings

    @byorgey
    byorgey committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8b395a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. fix unification code, and derive some necessary instances

    @byorgey
    byorgey committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    aa0e056 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. start converting Swarm.Language.Typecheck away from unification-fd

    @byorgey
    byorgey committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7a03018 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. bit more conversion

    @byorgey
    byorgey committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8524418 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. WIP: work on adding unification effect

    @byorgey
    byorgey committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    dee9b1e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. WIP: implement basic unification

    @byorgey
    byorgey committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    b16ddec View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. WIP: generalize unification a bit

    @byorgey
    byorgey committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ba30a71 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. WIP: work on unification effect

    @byorgey
    byorgey committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    402ddc2 View commit details
    Browse the repository at this point in the history

  2. WIP: bit of work converting old code

    @byorgey
    byorgey committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9a2ed46 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. more unification effect operations

    @byorgey
    byorgey committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    26d7242 View commit details
    Browse the repository at this point in the history

  2. WIP: convert some typechecking things to new framework

    @byorgey
    byorgey committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5f3345e View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. WIP: convert more typechecking things

    @byorgey
    byorgey committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1df0b2d View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. WIP: get runTC working, progress on uncommenting things

    @byorgey
    byorgey committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e3b1fe5 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. WIP: get most of Typecheck working 

    Now getting weird compile-time errors from some quasiquotes
    @byorgey
    byorgey committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    78fe0d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. WIP: fix bug in subst 

    Now it compiles but almost everything in the test suite is failing =)
    @byorgey
    byorgey committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8d651fb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. refactor + formatting

    @byorgey
    byorgey committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d33f82e View commit details
    Browse the repository at this point in the history

  2. refactoring, cleanup, fix comment, fix pretty-printing bug

    @byorgey
    byorgey committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ae54401 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. fix definition of substitution composition 

    Composition of substitutions is not commutative!
    @byorgey
    byorgey committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f7dd9a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. add a todo

    @byorgey
    byorgey committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a31056e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. refactor: rearrange some code

    @byorgey
    byorgey committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e5b4d3e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. split out naive unification carrier to separate module

    @byorgey
    byorgey committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    242b966 View commit details
    Browse the repository at this point in the history

  2. fix .cabal and formatting

    @byorgey
    byorgey committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0e7ab3d View commit details
    Browse the repository at this point in the history

  3. remove unneeded LANGUAGE pragmas

    @byorgey
    byorgey committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3118a13 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. first cut at a faster implementation of unification 

    Compared to the naive implementation, this brings down the time to run
the whole test suite from ~190 to ~140 seconds---though still slower
than unification-fd (~120s), which is to be expected.
    @byorgey
    byorgey committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    3ce440d View commit details
    Browse the repository at this point in the history

  2. make use of utility histogram function

    @byorgey
    byorgey committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    baa2cc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. some documentation, and fix bug

    @byorgey
    byorgey committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4b42098 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. comments, remove commented-out code

    @byorgey
    byorgey committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c766cfc View commit details
    Browse the repository at this point in the history

  2. code cleanup + comments

    @byorgey
    byorgey committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9bc9fef View commit details
    Browse the repository at this point in the history

  3. factor out common unification infrastructure into new module

    @byorgey
    byorgey committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2bc52b1 View commit details
    Browse the repository at this point in the history

  4. remove dead-end exploration

    @byorgey
    byorgey committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bcdf6a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. cleanup and comments

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4228e3e View commit details
    Browse the repository at this point in the history

  2. Restyled by fourmolu (#1803) 

    Co-authored-by: Restyled.io <commits@restyled.io>
    @restyled-io @restyled-commits
    restyled-io[bot] and restyled-commits committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e0e0ab8 View commit details
    Browse the repository at this point in the history

  3. get rid of unifyCheck; it now does the same as unification itself

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1dc6abb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refactor/custom-unification' of github.com:swarm-game/s… 

    …warm into refactor/custom-unification
    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4939ff1 View commit details
    Browse the repository at this point in the history

  5. apply cabal-gild

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a3a7e1d View commit details
    Browse the repository at this point in the history

  6. update cabal-gild version

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    217682d View commit details
    Browse the repository at this point in the history

  7. update to cabal-gild-setup-action@v2 

    See https://github.com/tfausak/cabal-gild-setup-action
    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    761a872 View commit details
    Browse the repository at this point in the history

  8. apply hlint hints

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fd25c6d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into refactor/custom-unification

    @byorgey
    byorgey committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a46f3ab View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. fix misspelling

    @byorgey
    byorgey committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b3e396a View commit details
    Browse the repository at this point in the history

  2. use insert instead of @@ with singleton as a small optimization

    @byorgey
    byorgey committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    496c7ef View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor/custom-unification

    @mergify
    mergify[bot] committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    1520994 View commit details
    Browse the repository at this point in the history