Refactor App using standalone functions #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `appMain` fit on screen. * Replace state `s1` and `s2` versions with `modifyIORef`.
xsebek
added
the
Z-Refactoring
byorgey
reviewed
Sep 1, 2024
| @@ -47,7 +56,7 @@ app eventHandler = | |||
| { appDraw = drawUI | |||
| , appChooseCursor = chooseCursor | |||
| , appHandleEvent = eventHandler | |||
| , appStartEvent = enablePasteMode | |||
| , appStartEvent = pure () | |||
There was a problem hiding this comment.
Why was enablePasteMode removed?
There was a problem hiding this comment.
I moved it to buildVty - I don't see why you would not want the paste mode on reinitialize, and we already have a similar mouse option set there.
When does the mode come into play? Currently, we only have a one-line REPL.
There was a problem hiding this comment.
Ah, it allows us to strip newlines and paste the whole definition into one line.
So it works with the refactor. 🙂
byorgey
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appMainfit on the screen.s1ands2versions withmodifyIORef.