layer-shell: add support for popups #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Jul 5, 2019
emersion
reviewed
Jul 5, 2019
ddevault
force-pushed
the
layer-shell-popups
branch
from
6db2511
to
0cc7be7
Compare
This comment has been minimized.
This comment has been minimized.
ddevault
force-pushed
the
layer-shell-popups
branch
2 times, most recently
from
b8ae21f
to
60a8cfd
Compare
|
This should be ready to go. |
emersion
reviewed
Jul 6, 2019
ddevault
force-pushed
the
layer-shell-popups
branch
2 times, most recently
from
ac9d297
to
08ad82b
Compare
|
Bump |
|
I'm testing this together with mate's wayland port of their panel.
Similar stuff happens with context menues on the panel. |
emersion
reviewed
Aug 1, 2019
emersion
reviewed
Aug 1, 2019
emersion
reviewed
Aug 1, 2019
ddevault
force-pushed
the
layer-shell-popups
branch
from
08ad82b
to
348bac5
Compare
|
Is this going to make it into 1.2 or is it planned for later? |
|
No, only bugfixes can make it. I was away so I couldn't get this reviewed in time for 1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports nested popups as well.