Skip to content

Commit

Permalink
feat(es/module): Improve error message about relative jsc.baseUrl (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
kdy1 committed Aug 17, 2023
1 parent ebbc929 commit 9099883
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions crates/swc_ecma_transforms_module/src/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,14 @@ where
if let Some(base_dir) = &base_dir {
assert!(
base_dir.is_absolute(),
"base_dir({}) must be absolute. Please ensure that `jsc.baseUrl` is specified \
correctly.",
"base_dir(`{}`) must be absolute. Please ensure that `jsc.baseUrl` is specified \
correctly. This cannot be deduced by SWC itself because SWC is a transpiler and \
it does not try to resolve project details. In other works, SWC does not know \
which directory should be used as a base directory. It can be deduced if \
`.swcrc` is used, but if not, there are many candidates. e.g. the directory \
containing `package.json`, or the current working directory. Because of that, \
the caller (typically the developer of the JavaScript package) should specify \
it. If you see this error, please report an issue to the package author.",
base_dir.display()
);
}
Expand Down

1 comment on commit 9099883

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 9099883 Previous: f8ca366 Ratio
es/full/bugs-1 293738 ns/iter (± 14685) 289445 ns/iter (± 7490) 1.01
es/full/minify/libraries/antd 1296700916 ns/iter (± 12577669) 1339135717 ns/iter (± 18090023) 0.97
es/full/minify/libraries/d3 271041513 ns/iter (± 2465526) 278971900 ns/iter (± 8912905) 0.97
es/full/minify/libraries/echarts 1038827232 ns/iter (± 4025243) 1069931080 ns/iter (± 15075173) 0.97
es/full/minify/libraries/jquery 83020024 ns/iter (± 274875) 83905890 ns/iter (± 308057) 0.99
es/full/minify/libraries/lodash 95973533 ns/iter (± 274387) 96708629 ns/iter (± 508711) 0.99
es/full/minify/libraries/moment 49128718 ns/iter (± 45639) 49056750 ns/iter (± 158787) 1.00
es/full/minify/libraries/react 17834193 ns/iter (± 80975) 17828827 ns/iter (± 81423) 1.00
es/full/minify/libraries/terser 217504520 ns/iter (± 2207134) 217783720 ns/iter (± 2072951) 1.00
es/full/minify/libraries/three 379141097 ns/iter (± 1079641) 389363289 ns/iter (± 3239848) 0.97
es/full/minify/libraries/typescript 2639666147 ns/iter (± 17164587) 2660491494 ns/iter (± 35279476) 0.99
es/full/minify/libraries/victory 556521307 ns/iter (± 2830884) 576965782 ns/iter (± 9197000) 0.96
es/full/minify/libraries/vue 117812164 ns/iter (± 474991) 118764874 ns/iter (± 907853) 0.99
es/full/codegen/es3 36267 ns/iter (± 75) 34142 ns/iter (± 59) 1.06
es/full/codegen/es5 36271 ns/iter (± 83) 34064 ns/iter (± 53) 1.06
es/full/codegen/es2015 36434 ns/iter (± 63) 34063 ns/iter (± 65) 1.07
es/full/codegen/es2016 36277 ns/iter (± 139) 34064 ns/iter (± 59) 1.06
es/full/codegen/es2017 36379 ns/iter (± 117) 34084 ns/iter (± 72) 1.07
es/full/codegen/es2018 36273 ns/iter (± 71) 34081 ns/iter (± 112) 1.06
es/full/codegen/es2019 36334 ns/iter (± 107) 34043 ns/iter (± 68) 1.07
es/full/codegen/es2020 36282 ns/iter (± 93) 34020 ns/iter (± 78) 1.07
es/full/all/es3 167678535 ns/iter (± 1286363) 166601630 ns/iter (± 1024119) 1.01
es/full/all/es5 160114035 ns/iter (± 817207) 159442438 ns/iter (± 2020502) 1.00
es/full/all/es2015 119058934 ns/iter (± 924795) 119457890 ns/iter (± 960235) 1.00
es/full/all/es2016 117783746 ns/iter (± 912457) 118706169 ns/iter (± 895879) 0.99
es/full/all/es2017 117014298 ns/iter (± 502499) 117724653 ns/iter (± 868067) 0.99
es/full/all/es2018 115318664 ns/iter (± 492105) 115530012 ns/iter (± 580610) 1.00
es/full/all/es2019 114394922 ns/iter (± 599357) 115127952 ns/iter (± 344390) 0.99
es/full/all/es2020 110069756 ns/iter (± 532523) 110336247 ns/iter (± 556070) 1.00
es/full/parser 505907 ns/iter (± 4463) 484277 ns/iter (± 4754) 1.04
es/full/base/fixer 18360 ns/iter (± 117) 17560 ns/iter (± 92) 1.05
es/full/base/resolver_and_hygiene 81156 ns/iter (± 257) 80045 ns/iter (± 203) 1.01
serialization of serde 294 ns/iter (± 0) 291 ns/iter (± 3) 1.01
css/minify/libraries/bootstrap 29488908 ns/iter (± 98890) 28577098 ns/iter (± 174746) 1.03
css/visitor/compare/clone 1642426 ns/iter (± 14112) 1653866 ns/iter (± 4006) 0.99
css/visitor/compare/visit_mut_span 1779596 ns/iter (± 8531) 1773586 ns/iter (± 8213) 1.00
css/visitor/compare/visit_mut_span_panic 1837334 ns/iter (± 8819) 1822089 ns/iter (± 6390) 1.01
css/visitor/compare/fold_span 2560154 ns/iter (± 11366) 2565957 ns/iter (± 14910) 1.00
css/visitor/compare/fold_span_panic 2758409 ns/iter (± 17666) 2753998 ns/iter (± 19094) 1.00
css/lexer/bootstrap_5_1_3 4440780 ns/iter (± 6017) 4424785 ns/iter (± 4926) 1.00
css/lexer/foundation_6_7_4 3786068 ns/iter (± 6710) 3721488 ns/iter (± 14849) 1.02
css/lexer/tailwind_3_1_1 726070 ns/iter (± 1079) 707212 ns/iter (± 671) 1.03
css/parser/bootstrap_5_1_3 19725747 ns/iter (± 41883) 19457595 ns/iter (± 62234) 1.01
css/parser/foundation_6_7_4 15289360 ns/iter (± 22158) 15442557 ns/iter (± 26508) 0.99
css/parser/tailwind_3_1_1 2999754 ns/iter (± 5925) 3013875 ns/iter (± 4080) 1.00
es/codegen/colors 730116 ns/iter (± 397179) 727364 ns/iter (± 396808) 1.00
es/codegen/large 2912228 ns/iter (± 1533243) 2917809 ns/iter (± 1534553) 1.00
es/codegen/with-parser/colors 45933 ns/iter (± 325) 46033 ns/iter (± 200) 1.00
es/codegen/with-parser/large 487556 ns/iter (± 2308) 498548 ns/iter (± 787) 0.98
es/minify/libraries/antd 1136488192 ns/iter (± 6888493) 1159970335 ns/iter (± 10872137) 0.98
es/minify/libraries/d3 237661251 ns/iter (± 948581) 240979493 ns/iter (± 1320244) 0.99
es/minify/libraries/echarts 904774683 ns/iter (± 7064071) 918879396 ns/iter (± 4174323) 0.98
es/minify/libraries/jquery 72860508 ns/iter (± 100984) 73148538 ns/iter (± 156939) 1.00
es/minify/libraries/lodash 86934528 ns/iter (± 130499) 87178366 ns/iter (± 145981) 1.00
es/minify/libraries/moment 43129045 ns/iter (± 53427) 43320628 ns/iter (± 119080) 1.00
es/minify/libraries/react 15976378 ns/iter (± 64676) 16001719 ns/iter (± 38543) 1.00
es/minify/libraries/terser 185146959 ns/iter (± 469707) 187125868 ns/iter (± 747497) 0.99
es/minify/libraries/three 320228381 ns/iter (± 1651591) 324609971 ns/iter (± 884477) 0.99
es/minify/libraries/typescript 2230754973 ns/iter (± 6933240) 2247989735 ns/iter (± 8721035) 0.99
es/minify/libraries/victory 467576736 ns/iter (± 1128265) 479694437 ns/iter (± 2783074) 0.97
es/minify/libraries/vue 105574571 ns/iter (± 167035) 106011502 ns/iter (± 219553) 1.00
es/visitor/compare/clone 1980886 ns/iter (± 14878) 1983223 ns/iter (± 9007) 1.00
es/visitor/compare/visit_mut_span 2291178 ns/iter (± 7604) 2289809 ns/iter (± 142716) 1.00
es/visitor/compare/visit_mut_span_panic 2345898 ns/iter (± 7118) 2351298 ns/iter (± 6513) 1.00
es/visitor/compare/fold_span 3417081 ns/iter (± 7300) 3415619 ns/iter (± 8234) 1.00
es/visitor/compare/fold_span_panic 3511772 ns/iter (± 4390) 3514167 ns/iter (± 10459) 1.00
es/lexer/colors 13086 ns/iter (± 146) 13217 ns/iter (± 82) 0.99
es/lexer/angular 6088156 ns/iter (± 36850) 6177837 ns/iter (± 4392) 0.99
es/lexer/backbone 792586 ns/iter (± 493) 789624 ns/iter (± 1645) 1.00
es/lexer/jquery 4498618 ns/iter (± 4188) 4521619 ns/iter (± 8893) 0.99
es/lexer/jquery mobile 6832736 ns/iter (± 5002) 6902795 ns/iter (± 15809) 0.99
es/lexer/mootools 3562215 ns/iter (± 2408) 3570073 ns/iter (± 9057) 1.00
es/lexer/underscore 661748 ns/iter (± 634) 662577 ns/iter (± 1342) 1.00
es/lexer/three 21306895 ns/iter (± 26404) 21406102 ns/iter (± 28440) 1.00
es/lexer/yui 3826707 ns/iter (± 1044) 3858740 ns/iter (± 7259) 0.99
es/parser/colors 27058 ns/iter (± 136) 27213 ns/iter (± 63) 0.99
es/parser/angular 13358149 ns/iter (± 56518) 13414386 ns/iter (± 60953) 1.00
es/parser/backbone 1985347 ns/iter (± 47973) 1995706 ns/iter (± 7566) 0.99
es/parser/jquery 10829431 ns/iter (± 42704) 10812438 ns/iter (± 42902) 1.00
es/parser/jquery mobile 16588943 ns/iter (± 150382) 16621468 ns/iter (± 59106) 1.00
es/parser/mootools 8314240 ns/iter (± 27141) 8353277 ns/iter (± 24774) 1.00
es/parser/underscore 1716827 ns/iter (± 8650) 1721727 ns/iter (± 8963) 1.00
es/parser/three 46336673 ns/iter (± 185872) 46435442 ns/iter (± 158872) 1.00
es/parser/yui 8192951 ns/iter (± 32279) 8233664 ns/iter (± 29908) 1.00
es/preset-env/usage/builtin_type 136135 ns/iter (± 31623) 135445 ns/iter (± 30802) 1.01
es/preset-env/usage/property 17608 ns/iter (± 125) 16994 ns/iter (± 64) 1.04
es/resolver/typescript 88484799 ns/iter (± 1032378) 87718749 ns/iter (± 1380048) 1.01
es/fixer/typescript 63247686 ns/iter (± 1307190) 61966915 ns/iter (± 297562) 1.02
es/hygiene/typescript 129159775 ns/iter (± 473086) 128369714 ns/iter (± 643458) 1.01
es/resolver_with_hygiene/typescript 239048431 ns/iter (± 879584) 237633238 ns/iter (± 1006103) 1.01
es/visitor/base-perf/module_clone 60002 ns/iter (± 271) 60541 ns/iter (± 285) 0.99
es/visitor/base-perf/fold_empty 64430 ns/iter (± 305) 64805 ns/iter (± 290) 0.99
es/visitor/base-perf/fold_noop_impl_all 64073 ns/iter (± 270) 64704 ns/iter (± 225) 0.99
es/visitor/base-perf/fold_noop_impl_vec 64758 ns/iter (± 305) 64695 ns/iter (± 231) 1.00
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 65 ns/iter (± 0) 0.86
es/visitor/base-perf/boxing_unboxed_clone 40 ns/iter (± 0) 38 ns/iter (± 0) 1.05
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 108 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 79 ns/iter (± 0) 1
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2780 ns/iter (± 15) 2627 ns/iter (± 15) 1.06
es/base/parallel/resolver/typescript 4207289015 ns/iter (± 201312857) 4527801831 ns/iter (± 320476080) 0.93
es/base/parallel/hygiene/typescript 1457577490 ns/iter (± 17887184) 1437070669 ns/iter (± 20565547) 1.01
misc/visitors/time-complexity/time 5 138 ns/iter (± 2) 133 ns/iter (± 0) 1.04
misc/visitors/time-complexity/time 10 389 ns/iter (± 2) 394 ns/iter (± 3) 0.99
misc/visitors/time-complexity/time 15 732 ns/iter (± 9) 520 ns/iter (± 2) 1.41
misc/visitors/time-complexity/time 20 1104 ns/iter (± 56) 1140 ns/iter (± 49) 0.97
misc/visitors/time-complexity/time 40 4094 ns/iter (± 14) 3834 ns/iter (± 77) 1.07
misc/visitors/time-complexity/time 60 7329 ns/iter (± 22) 7472 ns/iter (± 50) 0.98
es/full-target/es2016 237909 ns/iter (± 1014) 233638 ns/iter (± 1481) 1.02
es/full-target/es2017 226763 ns/iter (± 943) 222275 ns/iter (± 542) 1.02
es/full-target/es2018 213661 ns/iter (± 821) 209753 ns/iter (± 875) 1.02
es2020_nullish_coalescing 71262 ns/iter (± 246) 71103 ns/iter (± 418) 1.00
es2020_optional_chaining 82879 ns/iter (± 218) 81779 ns/iter (± 170) 1.01
es2022_class_properties 116704 ns/iter (± 518) 115128 ns/iter (± 624) 1.01
es2018_object_rest_spread 76087 ns/iter (± 251) 75467 ns/iter (± 383) 1.01
es2019_optional_catch_binding 65037 ns/iter (± 346) 64778 ns/iter (± 285) 1.00
es2017_async_to_generator 65147 ns/iter (± 143) 65743 ns/iter (± 144) 0.99
es2016_exponentiation 68725 ns/iter (± 212) 69069 ns/iter (± 242) 1.00
es2015_arrow 72174 ns/iter (± 210) 72342 ns/iter (± 168) 1.00
es2015_block_scoped_fn 68309 ns/iter (± 142) 68955 ns/iter (± 218) 0.99
es2015_block_scoping 125877 ns/iter (± 879) 123929 ns/iter (± 421) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.