Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swc): Fix bugs #1372

Merged
merged 23 commits into from
Feb 10, 2021
Merged

fix(swc): Fix bugs #1372

merged 23 commits into from
Feb 10, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 31, 2021

Tasks

swc_ecma_ast:

  • Support import assertions for exports.

swc_ecma_parser:

  • Support import assertions for exports.

swc_ecma_transform_typescript:

spack:

  • Re-enable multi-entry tests.

@kdy1 kdy1 added this to the v1.2.48 milestone Jan 31, 2021
@kdy1 kdy1 self-assigned this Jan 31, 2021
@kdy1 kdy1 mentioned this pull request Feb 1, 2021
3 tasks
@wycats
Copy link
Contributor

wycats commented Feb 9, 2021

@kdy1 is multi-entry currently broken? I was trying to use it and I get a hang followed by a:

FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory

@kdy1
Copy link
Member Author

kdy1 commented Feb 10, 2021

@wycats Yes, but JavaScript heap out of memory seems unrelated to the bug.

@kdy1 kdy1 changed the title fix(swc): Prepare v1.2.48 fix(swc): Fix bugs Feb 10, 2021
@kdy1 kdy1 marked this pull request as ready for review February 10, 2021 08:25
@kdy1 kdy1 merged commit bf445a7 into swc-project:master Feb 10, 2021
@kdy1 kdy1 deleted the bugs branch February 10, 2021 08:25
kdy1 added a commit to bartlomieju/swc that referenced this pull request Feb 10, 2021
swc_ecma_ast:
 - Support import assertions for exports.

swc_ecma_parser:
 - Support import assertions for exports.

swc_ecma_transform_typescript:
 - Strip `declare globals` correctly. (swc-project#1383)

spack:
 - Re-enable multi-entry tests.
@wycats
Copy link
Contributor

wycats commented Feb 10, 2021

@kdy1 is there anything I can do to help you reproduce it?

@kdy1
Copy link
Member Author

kdy1 commented Feb 11, 2021

@wycats Is your project open source?
If not, can you share your spack.config.js?

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

declare global is not stripped correctly anymore
2 participants