Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es): Apply paren_remover for minify #8442

Merged
merged 2 commits into from
Dec 23, 2023
Merged

fix(es): Apply paren_remover for minify #8442

merged 2 commits into from
Dec 23, 2023

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):
Closes #8437

@Austaras Austaras requested a review from a team as a code owner December 20, 2023 18:12
@Austaras
Copy link
Member Author

Not really sure how to add a test for this.

@kdy1
Copy link
Member

kdy1 commented Dec 21, 2023

You may add a test to https://github.com/swc-project/swc/blob/2ef9ed663a3bed76fd6dba537af2cd7c95b8406f/node-swc/__tests__/minify_test.mjs

@Austaras Austaras requested a review from a team as a code owner December 21, 2023 18:00
@kdy1 kdy1 added this to the Planned milestone Dec 21, 2023
@Austaras Austaras mentioned this pull request Dec 22, 2023
Closed
kdy1
kdy1 approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc

@kdy1 kdy1 changed the title fix(swc): Apply paren_remover for minify fix(es): Apply paren_remover for minify Dec 23, 2023
@kdy1 kdy1 enabled auto-merge (squash) December 23, 2023 03:39
@kdy1 kdy1 added the automerge label Dec 23, 2023
@kdy1 kdy1 merged commit e68720a into swc-project:main Dec 23, 2023
276 checks passed
@Austaras Austaras mentioned this pull request Dec 29, 2023
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.102 Dec 31, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
automerge
Milestone
v1.3.102
Development

Successfully merging this pull request may close these issues.

The minify method of @swc/core changes the order in which statements are executed
2 participants
@Austaras @kdy1