Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake patches for QNX Support #178

Merged
merged 4 commits into from
Sep 6, 2024
Merged

CMake patches for QNX Support #178

merged 4 commits into from
Sep 6, 2024

Conversation

adharsh
Copy link
Contributor

@adharsh adharsh commented Sep 5, 2024 •
edited
Loading

Patches to support building Starling on QNX

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adharsh adharsh marked this pull request as ready for review September 5, 2024 15:40
@adharsh adharsh requested a review from a team as a code owner September 5, 2024 15:40
@pcrumley
Copy link

pcrumley commented Sep 6, 2024

will any of this work need to be ported/implemented for Bazel?

@adharsh
Copy link
Contributor Author

adharsh commented Sep 6, 2024

will any of this work need to be ported/implemented for Bazel?
Yup! That's the plan, the goal is to first get the CMake build to work

@adharsh adharsh merged commit 5d9f739 into master Sep 6, 2024
2 checks passed
@adharsh adharsh deleted the ababu/imar_patches branch September 6, 2024 04:14
This was referenced Sep 6, 2024
Open
Open
adharsh added a commit that referenced this pull request Sep 19, 2024
@adharsh
Revert "CMake patches for QNX Support (#178)"
53c2c5d 
This reverts commit 5d9f739.
adharsh added a commit that referenced this pull request Sep 20, 2024
@adharsh
Revert "CMake patches for QNX Support (#178)" (#179)
87ff9df 
This reverts commit 5d9f739.

The QNX-specific changes have been moved to the relevant repos instead,
as they don't belong in the general cmake rules.
This was referenced Sep 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljbade ljbade ljbade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adharsh @pcrumley @ljbade @reimerix