[CAS] Don't create the same CAS multiple times from the same Oracle #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
akyrtzi
reviewed
Dec 19, 2023
...s/SwiftDriver/ExplicitModuleBuilds/InterModuleDependencies/InterModuleDependencyOracle.swift
Outdated
Show resolved
Hide resolved
cachemeifyoucan
force-pushed
the
eng/PR-119889879
branch
from
fbc27b6
to
f7e93e5
Compare
|
@swift-ci please test |
akyrtzi
reviewed
Dec 20, 2023
| createdCASMap[path] = CASConfig(onDiskPath: onDiskPath, pluginPath: pluginPath, pluginOptions: pluginOptions, cas: cas) | ||
| return cas | ||
| } | ||
| // If onDiskPath is nil, just create a new CAS. |
There was a problem hiding this comment.
Since the client will end up depending on getOrCreateCAS to avoid creating separate CAS instances for every Swift invocation, could you also share CAS instances even if onDiskPath is nil (in case passing nil onDiskPath becomes important in the future), using pluginPath+pluginOptions as key in a separate dictionary?
If the oracle has been used to create a CAS for the path, reuse the CAS if it is asked to create the same CAS again. This not only save the work of creating the CAS, but also avoid a potential problem that the CAS closing synchronization doesn't work across threads in the same process due to its uses of file lock.
cachemeifyoucan
force-pushed
the
eng/PR-119889879
branch
from
f7e93e5
to
60f3a10
Compare
akyrtzi
approved these changes
Dec 21, 2023
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the oracle has been used to create a CAS for the path, reuse the CAS if it is asked to create the same CAS again. This not only save the work of creating the CAS, but also avoid a potential problem that the CAS closing synchronization doesn't work across threads in the same process due to its uses of file lock.