Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough -tools-directory as -B to clang linker for Wasm target #1551

Merged

Conversation

kateinoigakukun
Copy link
Member

This change makes the clang linker driver for Wasm targets respect the -tools-directory option. This is necessary to use linker tools from Swift SDK toolset.

This change makes the clang linker driver for Wasm targets respect the
`-tools-directory` option. This is necessary to use linker tools from
Swift SDK toolset.
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test

Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@kateinoigakukun
Copy link
Member Author

@swift-ci test windows

1 similar comment
@kateinoigakukun
Copy link
Member Author

@swift-ci test windows

@kateinoigakukun kateinoigakukun merged commit 92507bd into swiftlang:main Feb 27, 2024
3 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/respect-tools-directory branch February 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants