Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set stdout and stderr encodings to UTF-8 in build-script-helper.py #1554

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Set stdout and stderr encodings to UTF-8 in build-script-helper.py #1554

merged 1 commit into from
Mar 5, 2024

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Mar 5, 2024

This will hopefully fix the following error that has been causing the https://ci.swift.org/job/oss-swift-RA-linux-ubuntu-18_04-long-test/ pipeline to fail for a few days:

UnicodeEncodeError: 'ascii' codec can't encode character '\u2502' in position 100311: ordinal not in range(128)

Resolves rdar://123809082

@tshortli
Copy link
Contributor Author

tshortli commented Mar 5, 2024

@swift-ci please test

artemcm
artemcm approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tshortli tshortli merged commit e0792ec into swiftlang:main Mar 5, 2024
3 checks passed
@tshortli tshortli deleted the ascii-codec-cant-encode branch March 5, 2024 16:21
@kastiglione kastiglione mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshortli @artemcm