Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0][Caching] Handle emit module job correctly for swift caching #1603

Merged
merged 1 commit into from
May 13, 2024
Merged

[6.0][Caching] Handle emit module job correctly for swift caching #1603

merged 1 commit into from
May 13, 2024

Commits on May 10, 2024

  1. [Caching] Handle emit module job correctly for swift caching 

    There are two situations when emiting modules are not correctly handled
when swift caching is enabled:
* When only `-emit-module` task is requested from driver, in this case,
  we are contructing a `CompileJob` but only generating module output.
  SwiftDriver still expects all swift inputs will have a cache key even
  only the first file is generating outputs and has a cache key.
* When using `-experimental-emit-module-separately`, then swift-driver
  needs to construct a `EmitModuleJob`, which wasn't taught the concept of
  caching and not producing any cache key.

rdar://127768967
(cherry picked from commit b5c3534)
    @cachemeifyoucan
    cachemeifyoucan committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a99d356 View commit details
    Browse the repository at this point in the history