Add FromVolumeFile time dependent option #6109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
force-pushed
the
dc_time_dep_opts_1
branch
from
50bb10c
to
85c0459
Compare
This was referenced Jun 25, 2024
nilsvu
requested changes
Jun 29, 2024
tests/Unit/Domain/Creators/TimeDependentOptions/Test_FromVolumeFile.cpp
Outdated
Show resolved
Hide resolved
Also renames the files now that they are in a directory: BinaryCompactObjectHelpers -> BinaryCompactObject ShapeMapOptions -> ShapeMap SphereTimeDependentMaps -> Sphere Also moved create_grid_anchors out of the BCOHelpers and just into the BCO file. This is all in anticipation of adding more time dep opts for different maps and not wanting to clutter the Domain/Creators directory.
knelli2
force-pushed
the
dc_time_dep_opts_1
branch
from
85c0459
to
e6827a9
Compare
|
@nilsvu Because of discussions over the past few days about reading in the FoTs exactly, I added a new commit that exposes all derivatives of a FoT. I then use that for the rotation and size FoTs in a fixup commit. |
|
squash |
knelli2
force-pushed
the
dc_time_dep_opts_1
branch
from
e6827a9
to
07b5152
Compare
nilsvu
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
First in a series of PRs that revamp the time dependent options of the Sphere and BCO domain creators.
Adds an option (not used yet) that can read functions of time that have been serialized in the volume data of an H5 file. The most recent commit of this PR contains the bulk of the changes. The other commits are just some organizational ones and don't contain any real changes.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments