Boolean function trait for Expressions #21

AurumTheEnd · 2024-04-22T20:30:56Z

No description provided.

codecov · 2024-04-22T20:34:14Z

Codecov Report

Attention: Patch coverage is 94.52055% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.54%. Comparing base (1e74737) to head (5c859bc).

Files	Patch %	Lines
src/bindings/expression.rs	0.00%	3 Missing ⚠️
src/bindings/table.rs	0.00%	3 Missing ⚠️
src/expressions/iterators/support.rs	92.85%	1 Missing ⚠️
src/utils/bool_point_to_valuation.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   78.99%   81.54%   +2.54%     
==========================================
  Files          39       49      +10     
  Lines         776      894     +118     
==========================================
+ Hits          613      729     +116     
- Misses        163      165       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Will be overwritten for BDDs.

…luation

Will come in handy for BDDs.

This satisfies BooleanFunctions's types DomainIterator, RangeIterator, RelationIterator, SupportIterator.

…ter methods

…c operator

Simplification should be handled separately.

…sion

… whitespace

…operators

…ply broken

…age reasons

…:from_csv

… Expression

daemontus and others added 2 commits April 22, 2024 21:21

feat: initial draft of the core trait operations.

7c131ab

fix: made BooleanFunction visible

f6e4d0d

AurumTheEnd added 10 commits April 23, 2024 12:10

refactor!: replaced all Hash* Sets, Maps, trait bounds with BTree/Ord

99abbd5

fix: clippy lints in tests

f9950b9

refactor: moved util methods from truthtable closer to their usage

65f6075

refactor: renamed row_index_to_valuation more aptly to _to_bool_point

0cb28ef

feat(bool fn trait): made weight have default implementation

ae81812

Will be overwritten for BDDs.

feat: added utility function for converting bool_point to BTreeMap va…

e9186f8

…luation

feat(expression): implemented BitXor trait to allow for the ^ operation

ac64239

build: enabled num-bigint feature for py03

5053114

Will come in handy for BDDs.

feat(bool fn trait): implemented iterator structs for Expression

68c68f7

This satisfies BooleanFunctions's types DomainIterator, RangeIterator, RelationIterator, SupportIterator.

feat(bool fn trait): began impl BooleanFunction for Expression with i…

a030f42

…ter methods

AurumTheEnd force-pushed the feat/boolean-function-trait branch from badfeae to a030f42 Compare April 25, 2024 16:58

AurumTheEnd added 5 commits April 26, 2024 10:47

feat(tests): added test for bitop collapse if sides are the same logi…

3c0975d

…c operator

refactor(expression/traits/bit): simplified imports

097e217

fix(bool fn trait): fixed documentation of restrict

0d07089

Simplification should be handled separately.

fix(bool fn trait): made ownership-passed parameters into references

79df2dd

feat(bool fn trait): finished implementing BooleanFunction for Expres…

1e37427

…sion

AurumTheEnd force-pushed the feat/boolean-function-trait branch from b6c1db8 to 1e37427 Compare April 26, 2024 18:11

AurumTheEnd added 10 commits April 26, 2024 21:04

feat(traits): added Implication trait

a98a90e

feat(expression): implemented Implication trait for Expression

da1ad3b

fix(truthtable): fixed from_csv_string messing up on leading/trailing…

f4f4d14

… whitespace

feat(tests): expanded table tests to use more from_csv_string

adf3064

fix(table): removed leftover comment from debugging

89c7933

feat(test): expanded xor test to account for merging behavior of bit …

5a453e4

…operators

fix(bool fn trait): fixed Expression's essential_inputs, that was sim…

700c4eb

…ply broken

fix(test): added tests for BooleanFunction default methods

7b3c351

refactor(expression): extracted util method

e138f66

fix(test): added Constant to expressions in test_substitute for cover…

b73392c

…age reasons

AurumTheEnd added 2 commits April 26, 2024 21:49

feat(test): tests for Expression's inputs and essential_inputs

c7efd64

refactor(bool fn trait): refactored SupportIterator to fix coverage bug

e9a8acc

AurumTheEnd force-pushed the feat/boolean-function-trait branch from 08dbe4e to e9a8acc Compare April 27, 2024 07:45

AurumTheEnd added 3 commits April 27, 2024 10:09

fix(tests): fixed Expression's BoolFunction test dependence on Table:…

ee42de5

…:from_csv

feat(tests): added basic tests for quantifications and derivative for…

f7bd511

… Expression

feat(tests): added basic test for is_implied_by for Expression

0fd53d1

AurumTheEnd changed the title ~~Draft: Boolean function trait~~ Boolean function trait Apr 27, 2024

AurumTheEnd requested a review from daemontus April 27, 2024 08:46

feat(tests): added basic test for is_equivalent for Expression

5c859bc

AurumTheEnd changed the title ~~Boolean function trait~~ Boolean function trait for Expressions Apr 27, 2024

AurumTheEnd mentioned this pull request May 2, 2024

Boolean function trait for TruthTable #24

Merged

daemontus merged commit dd44a31 into main May 2, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boolean function trait for Expressions #21

Boolean function trait for Expressions #21

AurumTheEnd commented Apr 22, 2024

codecov bot commented Apr 22, 2024 •

edited

Loading

Boolean function trait for Expressions #21

Boolean function trait for Expressions #21

Conversation

AurumTheEnd commented Apr 22, 2024

codecov bot commented Apr 22, 2024 • edited Loading

Codecov Report

codecov bot commented Apr 22, 2024 •

edited

Loading