Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar syntax #94

Merged
merged 14 commits into from
Feb 26, 2024

Conversation

mopichalova
Copy link
Collaborator

Order of individual sections (rules, inits, etc) is arbitrary now to allow more flexibility

  • rules must be defined at least once
  • each section can be defined more than once

Enforcing and accepting newlines:

  • ignoring only WS_INLINE instead of all WS
  • specifying where newlines are allowed

Close #93

@xtrojak xtrojak self-requested a review February 13, 2024 10:44
Comment on lines 607 to 612
if key == 'inits':
inits = value
if key == 'definitions':
definitions = value
if key == 'regulation':
regulation = value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be dict.update again somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, dict.update solved the issue in commit 8546c4e.
Commit 1ba38d2 handles multiple regulation definitions by throwing an exception.

eBCSgen/Parsing/ParseBCSL.py Outdated Show resolved Hide resolved
@xtrojak xtrojak merged commit 230b374 into sybila:improve-parsing Feb 26, 2024
1 of 2 checks passed
@xtrojak xtrojak mentioned this pull request Feb 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants