Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 as a test #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

and-semakin
Copy link
Contributor

No description provided.

Base automatically changed from master to main February 15, 2021 20:06
@@ -9,7 +9,7 @@
class Flake8RunnerTest(unittest.TestCase):
def test_run_flake8(self):
proj_root = pathlib.Path(__file__).parent.parent
paths = [proj_root / dirname for dirname in test_modules]
paths = [str(proj_root / dirname) for dirname in test_modules]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that Python 3.5 is EOL, is this still necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify, what exactly do you mean? Conversion to a str?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants