Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 98 fips 186 4 prime selection tentative #219

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RichardThiessen
Copy link

This fixes issue 98 and has a one extra effect:

  • small performance bump 1.3x faster keygen
    • the new sqrt(2) based bounds mean 2 primes are generated instead of an average of ~2.7

@RichardThiessen
Copy link
Author

Unit tests all pass now. Maybe that was the problem. If so, that's resolved.

If there's something else that needs to be done to get this up-streamed please tell me. I'm hoping this issue can finally be fixed after all these years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant