feat: configuration setup #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go Test coverage is 90.0 %\ ✨ ✨ ✨ |
|
Go Test coverage is 90.0 %\ ✨ ✨ ✨ |
mpetrun5
requested review from
tcar121293,
MakMuftic,
nmlinaric,
P1sar and
mj52951
|
Go Test coverage is 90.0 %\ ✨ ✨ ✨ |
|
Go Test coverage is 100.0 %\ ✨ ✨ ✨ |
2 similar comments
|
Go Test coverage is 100.0 %\ ✨ ✨ ✨ |
|
Go Test coverage is 100.0 %\ ✨ ✨ ✨ |
mpetrun5
force-pushed
the
mpetrun5/initial-config-setup
branch
from
5ee6841
to
d8c9e38
Compare
|
Go Test coverage is 100.0 %\ ✨ ✨ ✨ |
|
Go Test coverage is 100.0 %\ ✨ ✨ ✨ |
MakMuftic
approved these changes
Oct 20, 2023
nmlinaric
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables basic configuration setup. It is done with the
emvconfiglibrary and all configuration is to be done with environment variables from now to prevent configuration hell.For docker-compose setup environment variables and expected to read from a dedicated file.
Closes: #1