Avoid extra memcpy when decoding avif #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to read the code several times... even though it's just a few lines that's a very cool optimization. Instead of having the library allocate the pixels, you did it manually and have control of it without memcpy() it to and from the library allocation. That's very cool. Thank you @qbnu |
sylikc
added a commit
that referenced
this pull request
Jun 15, 2023
…w allocates and frees the memory instead of calling avifRGBImageAllocatePixels/avifRGBImageFreePixels Merge PR #208 by https://github.com/qbnu
sylikc
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can allocate space for each AVIF frame ourselves and decode into it, avoiding having to copy once it's been decoded. It will be freed later once it's been displayed.