Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JXL/HEIF/AVIF/WebP/PNG Exif data support #213
JXL/HEIF/AVIF/WebP/PNG Exif data support #213
Changes from all commits
7fd982b
0b2a7f0
6fab641
2ce3887
e1852b2
84eec26
d029446
1808e05
51487e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where's the magic 65538 number come from? I see it in other EXIF chunks of the code, where size+some number is 65538. It's an odd number, not a power of 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These libraries all have their own ideas about where to start the Exif data from. JPEG Exif blocks are in the format
FF E1 SS SS 45 78 69 66 00 00 [data]
. TheSS SS
is a big-endian unsigned short representing the size of everything afterFF E1
.libjxl gives
00 00 00 00 [data]
, libheif gives00 00 00 00 45 78 69 66 00 00 [data]
, libavif, libwebp and libpng give[data]
, so they have different limits for size. If you want I can change it to 65536 + an offset and add notes explaining why.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, now it makes sense. Regarding the documentation, I'll just refer to this comment. This is good investigative information.