[VarDumper] Fix dumping ArrayObject with DumpDataCollector
#50960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith full stack fmk
HypeMC
force-pushed
the
fix-dumping-arrayobject
branch
from
092bda8
to
1058e35
Compare
nicolas-grekas
approved these changes
Jul 13, 2023
src/Symfony/Component/VarDumper/Dumper/ContextProvider/SourceContextProvider.php
Outdated
Show resolved
Hide resolved
HypeMC
force-pushed
the
fix-dumping-arrayobject
branch
from
1058e35
to
b25f377
Compare
|
Thank you @HypeMC. |
This was referenced Jul 29, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem here is that the
ArrayObjectstoragekey in the array returned by__debugInfo()seems to be a reference: https://3v4l.org/8rSFn (a bug in PHP perhaps?)Since the
DumpDataCollectordoes the actual dumping in the__destructor()theArrayObjectstorageis modified by then which messes with the object created by theVarCloner.