Skip to content

Commit

Permalink
feature #983 Allow less-loader v9 (bobvandevijver, weaverryan)
Browse files Browse the repository at this point in the history
This PR was merged into the main branch.

Discussion
----------

Allow less-loader v9

I'm not sure what the policy on node compatibility is, but the latest major of `less-loader` only seems to drop Node 10 support ([release notes](https://github.com/webpack-contrib/less-loader/blob/master/CHANGELOG.md)).

Webpack Encore still supports Node 10, but that should still be possible if you use one of the other allowed less loaders.

Commits
-------

8ab906e working around node 10 and less-loader 9 in the test suite
b5986ca Allow less-loader v9
  • Loading branch information
weaverryan committed May 31, 2021
2 parents 972c882 + 8ab906e commit 37c6b37
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/node-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
# needed so that Node 10 downloads a compatible less-loader version
- name: Clear lock file
run: del yarn.lock
- name: yarn install
run: yarn install
run: yarn --ignore-engines
- name: run tests
run: yarn test
6 changes: 5 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@ matrix:
- rm yarn.lock
- yarn
- os: linux
node_js: "10"
node_js: "14"
env: JOB_PART=travis:lint
- os: linux
node_js: "10"
env: JOB_PART=test
# needed so that Node 10 downloads a compatible less-loader version
install:
- rm yarn.lock
- yarn --ignore-engines
- os: linux
node_js: "12"
env: JOB_PART=test
Expand Down
2 changes: 1 addition & 1 deletion package.json
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"handlebars-loader": "^1.7.0",
"http-server": "^0.12.3",
"less": "^4.0.0",
"less-loader": "^7.0.0 || ^8.0.0",
"less-loader": "^7.0.0 || ^8.0.0 || ^9.0.0",
"mocha": "^8.2.1",
"postcss": "^8.1.0",
"postcss-loader": "^4.0.0 || ^5.0.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -4455,10 +4455,10 @@ left-pad@^1.3.0:
resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.3.0.tgz#5b8a3a7765dfe001261dde915589e782f8c94d1e"
integrity sha512-XI5MPzVNApjAyhQzphX8BkmKsKUxD4LdyK24iZeQGinBN9yTQT3bFlCBy/aVx2HrNcqQGsdot8ghrjyrvMCoEA==

"less-loader@^7.0.0 || ^8.0.0":
version "8.1.1"
resolved "https://registry.yarnpkg.com/less-loader/-/less-loader-8.1.1.tgz#ababe912580457ad00a4318146aac5b53e023f42"
integrity sha512-K93jJU7fi3n6rxVvzp8Cb88Uy9tcQKfHlkoezHwKILXhlNYiRQl4yowLIkQqmBXOH/5I8yoKiYeIf781HGkW9g==
"less-loader@^7.0.0 || ^8.0.0 || ^9.0.0":
version "9.0.0"
resolved "https://registry.yarnpkg.com/less-loader/-/less-loader-9.0.0.tgz#71a0b530174bddf89bb11a5019dd725f54df4791"
integrity sha512-bPen1xeGTZuYFFobcdz9kMUVgSSSDZQJtyhawtCtcz1QboQOwhkI7uCwp5UO+IZpO+LJS1W73YwxsufbBT6SBQ==
dependencies:
klona "^2.0.4"

Expand Down

0 comments on commit 37c6b37

Please sign in to comment.