Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fork-ts-checker-webpack-plugin ^8.0 and ^9.0 #1224

Merged

Conversation

buffcode
Copy link
Contributor

Widen allowed scope of fork-ts-checker-webpack-plugin to v8 and v9.

@buffcode
Copy link
Contributor Author

Failing test seems to be unrelated to this MR:

  1) The config-generator function
       enableEslintPlugin() adds the eslint-webpack-plugin
         enableEslintPlugin():
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (D:\a\webpack-encore\webpack-encore\test\config-generator.js)
      at processImmediate (node:internal/timers:466:21)

@weaverryan
Copy link
Member

Thanks @buffcode!

@weaverryan weaverryan merged commit f6ae192 into symfony:main Oct 20, 2023
27 of 28 checks passed
@buffcode buffcode deleted the feat/fork-ts-checker-webpack-plugin branch October 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants