#936: Fix manifest key problem when using copy files

[bobvandevijver]

So, the solution for #936 was not complex at all, but creating a failing test was.

I needed to update the test scripts in the package.json, as webpack simply doesn't write it's cache until the mocha process ends. I did not find an alternative way to trigger the cache files to be written.

So, I separated the persistent cache tests into a dedicated directory/file, which is ignored during the normal test run. I added commands to run the persistent cache test both with and without previous cache (using the CLEAR_PERSISTENT_CACHE environment variable), and updated the original test command to run the normal test once, and the persistent cache tests twice (so the second run is with a valid cache).

I also needed to update the temp directory generation for the persistent cache, as it need to be deterministic over multiple cache runs. This is done with an extra parameter when creating the webpack configuration. This also makes sure that the webpack persistent cache is not shared over multiple tests (as long as you use unique keys obviously.

Just let me know if something needs to be done different!

[weaverryan]

This is awesome! I'm SO happy someone was able to find the fix - thank you! I just have a few minor comments about the test organization... and hopefully slimming down (removing) the new dev dependencies.

Thanks!

[bobvandevijver]

Alright, everything has been adjusted according to the feedback, so it should be ready for merge 👍🏻

I did not force push it, but I would combine 2924b67 with ac91584 and fe83b5d with d1aa7b2 to get a nice history.

[bobvandevijver]

@weaverryan Is there anything left to do for me before this can be merged and released?

[weaverryan]

Thank you Bob! This is truly an exciting PR :D :D