Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
fix(build): release tagging
Browse files Browse the repository at this point in the history
Turns out we were creating GitHub releases for `master` branch and then
force updating them to tag. This changes the process so we first push
the git tag and then create a GitHub release based off of the current
checked out commit.

(cherry picked from commit c5b48f9)
  • Loading branch information
zregvart committed Apr 3, 2020
1 parent 3ba0de7 commit 8290549
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions tools/bin/commands/release
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,16 @@ release::run() {
prerelease=true
fi

# Push everything (if configured)
git_push "$topdir" "$release_version" "$moving_tag"

# Release the binaries
publish_artifacts "${topdir}" "$release_version" $prerelease

# Create release description based on commit between releases
# if check_for_command gren; then
# gren release --data-source=commits --tags=$release_version --override
# fi

# Push everything (if configured)
git_push "$topdir" "$release_version" "$moving_tag"
}

create_moving_tag_release() {
Expand Down Expand Up @@ -298,6 +298,7 @@ publish_artifacts() {
local data="{\
\"tag_name\": \"${tag}\", \
\"name\": \"${tag}\", \
\"target_commitish\": \"$(git rev-parse HEAD)\", \
\"prerelease\": ${prerelease} \
}"

Expand Down

0 comments on commit 8290549

Please sign in to comment.