fix: improve performance of amber sort

src/syrupy/extensions/amber/serializer.py

@@ -11,7 +11,6 @@
     Dict,
     Generator,
     Iterable,
-    List,
     NamedTuple,
     Optional,
     Set,
@@ -104,8 +103,15 @@ def __maybe_int(cls, part: str) -> Tuple[int, Union[str, int]]:
     @classmethod
     def __snapshot_sort_key(
         cls, snapshot: "Snapshot"
-    ) -> List[Tuple[int, Union[str, int]]]:
-        return [cls.__maybe_int(part) for part in snapshot.name.split(".")]
+    ) -> Tuple[Tuple[int, Union[str, int]], ...]:
+        # we only need to sort the last part of the snapshot name
+        index = snapshot.name.rfind(".") + 1
+        if index:
+            return (
+                (0, snapshot.name[: index - 1]),
+                cls.__maybe_int(snapshot.name[index:]),
+            )
+        return ((0, snapshot.name),)
 
     @classmethod
     def write_file(

tests/syrupy/__snapshots__/test_doctest.ambr

@@ -9,9 +9,6 @@
     nested_obj_attr='nested doc test class attr',
   )
 # ---
-# name: DocTestClass.NestedDocTestClass.doctest_method
-  'nested doc test method return value'
-# ---
 # name: DocTestClass.doctest_method
   'doc test method return value'
 # ---
@@ -20,6 +17,9 @@
     obj_attr='test class attr',
   )
 # ---
+# name: DocTestClass.NestedDocTestClass.doctest_method
+  'nested doc test method return value'
+# ---
 # name: doctest_fn
   'doc test fn return value'
 # ---

tests/syrupy/extensions/amber/__snapshots__/test_amber_serializer.ambr

@@ -1,13 +1,4 @@
 # serializer version: 1
-# name: TestClass.TestNestedClass.test_nested_class_method[x]
-  'parameterized nested class method x'
-# ---
-# name: TestClass.TestNestedClass.test_nested_class_method[y]
-  'parameterized nested class method y'
-# ---
-# name: TestClass.TestNestedClass.test_nested_class_method[z]
-  'parameterized nested class method z'
-# ---
 # name: TestClass.test_class_method_name
   'this is in a test class'
 # ---
@@ -20,13 +11,13 @@
 # name: TestClass.test_class_method_parametrized[c]
   'c'
 # ---
-# name: TestSubClass.TestNestedClass.test_nested_class_method[x]
+# name: TestClass.TestNestedClass.test_nested_class_method[x]
   'parameterized nested class method x'
 # ---
-# name: TestSubClass.TestNestedClass.test_nested_class_method[y]
+# name: TestClass.TestNestedClass.test_nested_class_method[y]
   'parameterized nested class method y'
 # ---
-# name: TestSubClass.TestNestedClass.test_nested_class_method[z]
+# name: TestClass.TestNestedClass.test_nested_class_method[z]
   'parameterized nested class method z'
 # ---
 # name: TestSubClass.test_class_method_name
@@ -41,6 +32,15 @@
 # name: TestSubClass.test_class_method_parametrized[c]
   'c'
 # ---
+# name: TestSubClass.TestNestedClass.test_nested_class_method[x]
+  'parameterized nested class method x'
+# ---
+# name: TestSubClass.TestNestedClass.test_nested_class_method[y]
+  'parameterized nested class method y'
+# ---
+# name: TestSubClass.TestNestedClass.test_nested_class_method[z]
+  'parameterized nested class method z'
+# ---
 # name: test_bool[False]
   False
 # ---