Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline strings should be indented to the same depth as the parent #193

Closed
noahnu opened this issue Apr 17, 2020 · 1 comment · Fixed by #192
Closed

Multiline strings should be indented to the same depth as the parent #193

noahnu opened this issue Apr 17, 2020 · 1 comment · Fixed by #192
Assignees
@noahnu
Labels
feature request New feature or request released
Milestone
v0.4.0

Comments

@noahnu
Copy link
Collaborator

noahnu commented Apr 17, 2020

Is your feature request related to a problem? Please describe.

Multiline strings span multiple lines in the amber snapshot but are not indented. This leads to hard to read snapshots.

Describe the solution you'd like

Use the same indentation rules as list/dict/other values. I.e. indent every line in the string.
@noahnu noahnu added this to the v0.4.0 milestone Apr 17, 2020
@noahnu noahnu self-assigned this Apr 17, 2020
noahnu pushed a commit that referenced this issue Apr 17, 2020
feat(amber): indent multiline strings, close #193
80468e7
@noahnu noahnu mentioned this issue Apr 17, 2020
Merged
2 tasks
@noahnu noahnu added the feature request New feature or request label Apr 17, 2020
noahnu pushed a commit that referenced this issue Apr 17, 2020
feat(amber): indent multiline strings, close #193 (#194)
d731fb3
noahnu pushed a commit that referenced this issue Apr 18, 2020
@noahnu
feat(amber): indent multiline strings, close #193 (#194)
8e6a522
@noahnu noahnu mentioned this issue Apr 19, 2020
Merged
2 tasks
noahnu pushed a commit that referenced this issue Apr 19, 2020
@noahnu
feat(amber): indent multiline strings, close #193 (#194)
de5af3e
syrupy-bot pushed a commit that referenced this issue Apr 19, 2020
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
32c55fe 
# [0.4.0](v0.3.12...v0.4.0) (2020-04-19)

### Bug Fixes

* remove added trailing whitespace from multiline string ([24f3d57](24f3d57))

### Features

* **amber:** indent multiline strings, close [#193](#193) ([#194](#194)) ([de5af3e](de5af3e))
@syrupy-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahnu noahnu

Labels
feature request New feature or request released
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

feat: v0.4.0 - Amber serializer changes syrupy-project/syrupy
2 participants
@noahnu @syrupy-bot