generated from tophat/new-project-kit
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amber): add property matcher support #245
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6e8e9a8
wip: add matcher named argument
iamogbz 188cdb2
fix: make arguments optional when using call syntax
iamogbz 5acaa76
feat(amber): add property matcher support
iamogbz fd6aed1
test: property matcher
iamogbz 2a87d54
test: property matcher
iamogbz 494a415
test: property matcher
iamogbz 023aaee
style: lint fix
iamogbz a25f1ff
Merge branch 'master' into property-matcher
iamogbz 06ff637
Merge branch 'master' into property-matcher
iamogbz 8601346
Merge branch 'master' into property-matcher
iamogbz 2203ca5
Merge branch 'master' into property-matcher
iamogbz 7d6db55
Merge branch 'master' into property-matcher
iamogbz c346450
docs: add documentation
iamogbz d1d2560
chore: update serialize kwargs
iamogbz 1cdf09e
feat: add path_type matcher factory helper
iamogbz da50aff
docs: update path type signature
iamogbz 9b4d72e
wip: include parent types in property path
iamogbz ca36eb7
Merge branch 'master' into property-matcher
iamogbz efde470
refactor: move types to explicit argument
iamogbz a710834
chore: more docs
iamogbz 8a0e62b
cr: update doc wording
iamogbz 6b060f9
refactor: split amber data serializer
iamogbz 76ea77e
style: formatting
iamogbz 6fa2405
refactor: reuse serialize logic
iamogbz 9d835c1
chore: remove unused type def
iamogbz bca40d2
chore: use gettext for messages
iamogbz 31bb9e4
refactor: reuse repr and kwargs
iamogbz cd82b38
refactor: repr init param
iamogbz 3153fd2
refactor: serializer to order functions by use
iamogbz 4438753
chore: add specific path type error
iamogbz 03dd8c4
Merge branch 'master' into property-matcher
iamogbz 8de6399
cr: update docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
tabWidth = 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it only work on class types? What about primitive types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primitives work as well e.g. https://github.com/tophat/syrupy/blob/6fa24059755cc29524ce223993bd3e6392ecb6d5/tests/test_matchers.py#L28-L33