feat(modules/cloud-logs): introduce cloud logs module for s3 onboarding #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobrick
suggested changes
Sep 19, 2024
| folder_arn = var.folder_arn | ||
| role_name = local.role_name | ||
| external_id = data.sysdig_secure_tenant_external_id.external_id.external_id | ||
| region = var.region |
There was a problem hiding this comment.
Before releasing this, let's remove the region, so we avoid "polluting" some other setups and come up with something clean. Ok to keep this on a branch for internal testing for now, but let's remove it before releasing, along with the variable etc.
There was a problem hiding this comment.
Agree. Will open a PR that extends this one and removes the region. So we can prepare backend changes in the meantime.
SKosier
force-pushed
the
skosier/integrations-s3/cloud-logs
branch
from
0d9da26
to
c914ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.