Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realpath library function #121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joshblum
Copy link

@joshblum joshblum commented Jan 5, 2024

No description provided.

@szwacz
Copy link
Owner

szwacz commented Jan 16, 2024

Thanks for the PR. I have problem finding windows dev machine to tinker with failed tests ;)
Will come back to it.

@joshblum
Copy link
Author

Took a guess at what the windows problem could be but also don't have a windows dev machine setup. Could you try running CI again on the change? Thanks!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: Patch coverage is 97.45763% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.94%. Comparing base (79f53db) to head (f211f50).

Files Patch % Lines
lib/realpath.js 90.47% 2 Missing ⚠️
spec/realpath.spec.ts 98.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   96.92%   96.94%   +0.01%     
==========================================
  Files          52       54       +2     
  Lines        4624     4740     +116     
  Branches       25       25              
==========================================
+ Hits         4482     4595     +113     
- Misses        123      126       +3     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants