Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amount range to lease_rate #1

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

t-bast
Copy link
Owner

@t-bast t-bast commented Mar 27, 2024

We add a minimum and maximum amount to the lease rate. This allows sellers to provide different rates depending on the amount that is purchased. Since the number of utxos used will likely vary based on the amount, this also lets them use more accurate funding weights to ensure they don't end up paying too much of the on-chain fees.

With that data added, a lease rate uses 24 bytes. We limit the number of rates in a node_announcement to 10, which doesn't make it too harmful in terms of bandwidth usage for the gossip network.

We add a minimum and maximum amount to the lease rate. This allows
sellers to provide different rates depending on the amount that is
purchased. Since the number of utxos used will likely vary based
on the amount, this also lets them use more accurate funding weights
to ensure they don't end up paying too much of the on-chain fees.

With that data added, a lease rate uses 24 bytes. We limit the number
of rates in a `node_announcement` to 10, which doesn't make it too
harmful in terms of bandwidth usage for the gossip network.
@t-bast
Copy link
Owner Author

t-bast commented Apr 10, 2024

@TheBlueMatt can you detail the fee fields you wanted to add? IIRC there was one related to lightning/blips#25 (but then isn't it an issue that the BOLTs reference a bLIP?) and the other one was some way of indicating a recurring payment?

@TheBlueMatt
Copy link

So there's a lot of things we need in general - we need to support JIT channels (and paying the lease_fee_* fees using lightning/blips#25) but I think we should also support an extra channel/forwarding/per-HTLC fee which can be paid using lightning/blips#25 (prop and absolute). From there we also need renewal fees/a renewal mechanism that charges fees.

@t-bast
Copy link
Owner Author

t-bast commented Apr 11, 2024

I'll go ahead and merge this into lightning#1145 for now. I'll work on a concurrent design for liquidity ads that is more flexible and will let us more easily extend the fee mechanisms. That will end-up being a separate spec PR, which may make lightning#1145 obsolete.

@t-bast t-bast merged commit 07e511f into advertize-liquidity-ads Apr 11, 2024
@t-bast t-bast deleted the advertize-liquidity-ads-range branch April 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants