Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deprecation warning with dart sass #56

Conversation

kedarvijaykulkarni
Copy link
Contributor

this is the fix for issue #55
the issue is related updates in scss
https://sass-lang.com/documentation/breaking-changes/slash-div

and this will resolve using the math.div function in the division of 100% in the width.
more about math function is available here

@cupofjoakim
Copy link

@johno (or some other maintainer) Could this get some feedback or a review? It's a very minor change and would be super nice to get in :)

@mrmrs mrmrs merged commit 2dce89b into tachyons-css:master Oct 5, 2021
@tim-lai
Copy link

tim-lai commented Jan 18, 2022

@mrmrs Thanks for merging this PR. Any chance we can get a version bump release with this PR? 😉

@jpesce
Copy link

jpesce commented Jan 10, 2023

@MrMs can we have a version bump/npm publish so this change is available for projects that rely on tachyons-sass?

Created a PR #68 if it makes this easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants