Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[work-in-progress] Decoding BufReader implementation #441

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[work-in-progress] Decoding BufReader implementation #441

wants to merge 8 commits into from

Commits on Jul 26, 2023

  1. Assume UTF-8 for regex matches 

    This code wouldn't have worked on any other encoding anyway
    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4b6f0c0 View commit details
    Browse the repository at this point in the history

  2. Add Utf8BytesReader infrastructure 

    When the source of the bytes isn't UTF-8 (or isn't known to be), the
bytes need to be decoded first, or at least validated as such. Wrap
'Read'ers with Utf8BytesReader to ensure this happens.

Defer the validating portion for now.
    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9c59d53 View commit details
    Browse the repository at this point in the history

  3. Remove test bom_from_reader 

    This is inside the check! macro, meaning it gets implemented per reader
type, but from_reader() doesn't apply to SliceReader
    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4b848b7 View commit details
    Browse the repository at this point in the history

  4. Move Reader::from_str() constructor alongside Reader::from_reader()

    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8a14c1a View commit details
    Browse the repository at this point in the history

  5. Convert namespace-related structs to str

    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0b38ea1 View commit details
    Browse the repository at this point in the history

  6. Update event and attribute related structs to str

    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    07c3a92 View commit details
    Browse the repository at this point in the history

  7. Remove quick_xml::encoding::Decoder and Reader::decoder() 

    As quick-xml will pre-decode everything, it is unnecessary.
    @dralley
    dralley committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    daf407e View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. temp

    @dralley
    dralley committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    22430bc View commit details
    Browse the repository at this point in the history