Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unnecessarily restrict create_element to borrowed names #722

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

2xsaiko
Copy link
Contributor

@2xsaiko 2xsaiko commented Feb 29, 2024

This allows passing owned strings to create_element by making the bounds for the name the same as in the parameter for BytesStart::new.

@Mingun
Copy link
Collaborator

Mingun commented Feb 29, 2024

Please add a changelog entry. Do not forget to add actual link in section with links, contributors frequently forget about that. Please keep the links list sorted by issue number.

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.24%. Comparing base (5d76174) to head (79d5d4c).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   61.24%   61.24%           
=======================================
  Files          39       39           
  Lines       16277    16277           
=======================================
  Hits         9969     9969           
  Misses       6308     6308           
Flag Coverage Δ
unittests 61.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mingun Mingun merged commit 2b2b773 into tafia:master Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants