Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk): add TuiValuesOf #4822

Merged
merged 1 commit into from
Jul 2, 2023
Merged

chore(cdk): add TuiValuesOf #4822

merged 1 commit into from
Jul 2, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Part of #4820

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 2, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jul 2, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
323.45KB (-98B -0.03%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.41KB +10%
demo/browser/runtime.(hash).js
38.19KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -100B -0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.26MB (-114B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is worth the feat, maybe chore?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Visit the preview URL for this PR (updated for commit 22beb78):

https://taiga-ui--pr4822-splincode-feat-type-pfzdzuv8.web.app

(expires Mon, 03 Jul 2023 13:38:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 ⚠️

Comparison is base (a5e1574) 69.67% compared to head (22beb78) 69.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4822      +/-   ##
==========================================
- Coverage   69.67%   69.66%   -0.01%     
==========================================
  Files        1575     1575              
  Lines       17265    17262       -3     
  Branches     2405     2404       -1     
==========================================
- Hits        12029    12026       -3     
  Misses       4839     4839              
  Partials      397      397              
Flag Coverage Δ
addon-charts 71.73% <ø> (ø)
addon-doc 59.69% <ø> (ø)
addon-editor 49.05% <ø> (ø)
addon-mobile 61.33% <ø> (ø)
addon-table 60.85% <0.00%> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 79.88% <100.00%> (+<0.01%) ⬆️
core 76.95% <100.00%> (-0.03%) ⬇️
kit 71.50% <ø> (ø)
summary 69.66% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...directives/table-filters/table-filter.directive.ts 38.09% <0.00%> (ø)
projects/cdk/utils/miscellaneous/uniq-by.ts 100.00% <ø> (ø)
projects/cdk/types/index.ts 100.00% <100.00%> (ø)
...rojects/core/components/expand/expand.component.ts 82.22% <100.00%> (-1.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode changed the title feat(cdk): add TuiValuesOf chore(cdk): add TuiValuesOf Jul 2, 2023
@splincode splincode merged commit 1587ccd into main Jul 2, 2023
42 checks passed
@splincode splincode deleted the splincode/feat/type branch July 2, 2023 14:56
@well-done-bot
Copy link

well-done-bot bot commented Jul 2, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants