Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add eslint rules for declare enums #4825

Merged
merged 1 commit into from
Jul 3, 2023
Merged

ci: add eslint rules for declare enums #4825

merged 1 commit into from
Jul 3, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Jul 2, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

Closes #4820

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 2, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jul 2, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
323.45KB +10%
demo/browser/vendor.(hash).js
200.41KB +10%
demo/browser/runtime.(hash).js
38.19KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.26MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Visit the preview URL for this PR (updated for commit ffafd5c):

https://taiga-ui--pr4825-splincode-ci-lint-0vjbzfho.web.app

(expires Mon, 03 Jul 2023 15:28:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0da06bb) 69.66% compared to head (ffafd5c) 69.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4825   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files        1575     1575           
  Lines       17262    17262           
  Branches     2404     2404           
=======================================
  Hits        12026    12026           
  Misses       4839     4839           
  Partials      397      397           
Flag Coverage Δ
addon-charts 71.73% <ø> (ø)
addon-doc 59.69% <ø> (ø)
addon-editor 49.05% <ø> (ø)
addon-mobile 61.33% <ø> (ø)
addon-table 60.85% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 79.88% <ø> (ø)
core 76.95% <ø> (ø)
kit 71.50% <ø> (ø)
summary 69.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/addon-commerce/enums/currency-code.ts 100.00% <ø> (ø)
...lumn-manager/table-row-column-manager.component.ts 50.00% <ø> (ø)
projects/addon-editor/enums/editor-tool.ts 100.00% <ø> (ø)
projects/cdk/enums/day-of-week.ts 100.00% <ø> (ø)
projects/cdk/enums/month-number.ts 100.00% <ø> (ø)
projects/cdk/observables/drag-and-drop-from.ts 100.00% <ø> (ø)
projects/core/enums/appearance.ts 100.00% <ø> (ø)
projects/core/enums/dropdown-animation.ts 100.00% <ø> (ø)
projects/core/enums/interactive-state.ts 100.00% <ø> (ø)
projects/core/enums/notification.ts 100.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 923975a into main Jul 3, 2023
44 checks passed
@splincode splincode deleted the splincode/ci/lint branch July 3, 2023 08:31
@well-done-bot
Copy link

well-done-bot bot commented Jul 3, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🤖 - Use const objects versus enams
2 participants