Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputInline fix width calculation #4878

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix(kit): InputInline fix width calculation #4878

merged 1 commit into from
Jul 10, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 10, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jul 10, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
323.71KB (+55B +0.02%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.6KB +10%
demo/browser/runtime.(hash).js
38.23KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +55B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.27MB (+55B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit e734c4e):

https://taiga-ui--pr4878-input-inline-gboakno4.web.app

(expires Tue, 11 Jul 2023 10:26:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: +0.01 🎉

Comparison is base (7328ae9) 69.56% compared to head (e734c4e) 69.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4878      +/-   ##
==========================================
+ Coverage   69.56%   69.57%   +0.01%     
==========================================
  Files        1587     1587              
  Lines       17304    17297       -7     
  Branches     2404     2402       -2     
==========================================
- Hits        12037    12034       -3     
+ Misses       4870     4866       -4     
  Partials      397      397              
Flag Coverage Δ
addon-charts 71.36% <ø> (ø)
addon-doc 59.50% <ø> (ø)
addon-editor 49.07% <ø> (ø)
addon-mobile 61.15% <ø> (ø)
addon-table 60.44% <ø> (ø)
addon-tablebars 92.72% <ø> (ø)
cdk 79.79% <ø> (ø)
core 76.92% <ø> (ø)
kit 71.49% <14.28%> (+0.03%) ⬆️
summary 69.57% <14.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/input-inline/input-inline.component.ts 60.00% <0.00%> (-15.00%) ⬇️
...it/components/input-phone/input-phone.component.ts 80.76% <33.33%> (+6.61%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 7518bf8 into main Jul 10, 2023
45 checks passed
@splincode splincode deleted the input-inline branch July 10, 2023 11:32
@well-done-bot
Copy link

well-done-bot bot commented Jul 10, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants