Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): Textarea use balance text-wrap in safari #8666

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix(legacy): Textarea use balance text-wrap in safari #8666

merged 2 commits into from
Aug 23, 2024

Conversation

vladimirpotekhin
Copy link
Member

@vladimirpotekhin vladimirpotekhin commented Aug 23, 2024 •
edited
Loading

Close #8608

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 23, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a0621d6):

https://taiga-previews--pr8666-fix-safari-textarea-9bnidinx.web.app

(expires Sat, 24 Aug 2024 11:52:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 23, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 281.07KB +10%
✅ demo/browser/vendor.(hash).js
 216.3KB +10%
✅ demo/browser/runtime.(hash).js
 41.67KB +10%
✅ demo/browser/styles.(hash).css
 11.55KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change +10B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 6.81MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin marked this pull request as ready for review August 23, 2024 11:49
@splincode splincode merged commit cbaac1b into main Aug 23, 2024
29 checks passed
@splincode splincode deleted the fix-safari-textarea branch August 23, 2024 12:26
vladimirpotekhin added a commit that referenced this pull request Aug 23, 2024
@vladimirpotekhin
fix(legacy): Textarea use balance text-wrap in safari (#8666)
3af88ce 
(cherry picked from commit cbaac1b)
vladimirpotekhin added a commit that referenced this pull request Aug 26, 2024
@vladimirpotekhin
fix(kit): Textarea use balance text-wrap in safari (#8666) (#8672)
06fb25a
This was referenced Aug 26, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Textarea has unexpected content shift in Safari
3 participants
@vladimirpotekhin @waterplea @splincode