Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing docs on the pin projection constant #78

Closed
wants to merge 2 commits into from

Conversation

notgull
Copy link
Sponsor

@notgull notgull commented Aug 6, 2023

Temporary fix for #77

Temporary fix for taiki-e#77

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Sponsor Author

notgull commented Aug 6, 2023

Is there a way to regenerate the tests there, or should I just modify them manually?

@taiki-e
Copy link
Owner

taiki-e commented Aug 6, 2023

Running cargo +nightly test --test expandtest regenerates these files. (See "Expansion tests" section in DEVELOPMENT.md for details.)

Signed-off-by: John Nunley <dev@notgull.net>
@taiki-e
Copy link
Owner

taiki-e commented Aug 9, 2023

I'm going to close this as this is not the correct fix to the problem and just hide the real problem, as mentioned in #77.

Thanks anyway for the PR.

@taiki-e taiki-e closed this Aug 9, 2023
@notgull notgull deleted the allow-missing-docs branch August 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants