Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4: Expand glob imports #335

Merged
merged 8 commits into from
Dec 26, 2021
Merged

0.4: Expand glob imports #335

merged 8 commits into from
Dec 26, 2021

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Dec 26, 2021

Backport of ab1f198.

0.4.28 and older versions are failed to compile with syn 1.0.84 and later.

error[E0659]: `parse_quote_spanned` is ambiguous
   --> pin-project-internal/src/pin_project/derive.rs:865:67
    |
865 |                 proj_generics.make_where_clause().predicates.push(parse_quote_spanned! { span =>
    |                                                                   ^^^^^^^^^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of a conflict between a `macro_rules` name and a non-`macro_rules` name from another module
note: `parse_quote_spanned` could refer to the macro defined here
   --> pin-project-internal/src/utils.rs:23:1
    |
23  | / macro_rules! parse_quote_spanned {
24  | |     ($span:expr => $($tt:tt)*) => {
25  | |         syn::parse2(quote::quote_spanned!($span => $($tt)*)).unwrap_or_else(|e| panic!("{}", e))
26  | |     };
27  | | }
    | |_^
note: `parse_quote_spanned` could also refer to the macro imported here
   --> pin-project-internal/src/pin_project/derive.rs:7:5
    |
7   |     *,
    |     ^
    = help: use `self::parse_quote_spanned` to refer to this macro unambiguously

See ddcd880 for v1.0.

@taiki-e taiki-e force-pushed the v0.4-imports branch 3 times, most recently from 160fb5b to 525cd91 Compare December 26, 2021 05:37
```text
warning: warn(unaligned_references) incompatible with previous forbid
  --> tests/lint.rs:20:5
   |
4  | #![forbid(future_incompatible, rust_2018_compatibility)]
   |           ------------------- `forbid` level set here
...
20 |     unaligned_references,
   |     ^^^^^^^^^^^^^^^^^^^^ overruled by previous forbid
```
@taiki-e
Copy link
Owner Author

taiki-e commented Dec 26, 2021

bors r+

@taiki-e
Copy link
Owner Author

taiki-e commented Dec 26, 2021

By the way, as of 2021/12/26, 0.4.28 is still being downloaded around 10,000 times a day (on weekdays).

@bors
Copy link
Contributor

bors bot commented Dec 26, 2021

Build succeeded:

@bors bors bot merged commit 2b6e71a into v0.4 Dec 26, 2021
@bors bors bot deleted the v0.4-imports branch December 26, 2021 06:09
taiki-e added a commit that referenced this pull request Dec 27, 2021
- 0.4.28 and older releases have been yanked because they failed to
  compile with syn 1.0.84 and later. See #335 for more.
- Mention the minimal version of syn increased in 1.0.9.
rillian added a commit to brave/brave-core that referenced this pull request Jan 19, 2022
This is a transitive dependency through futures-retry.

The 0.4.28 version was yanked for compile errors with syn 1.0.84
and later. See taiki-e/pin-project#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant