fix(raiko): refine error return #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Signed-off-by: smtmfft <smtm@taiko.xyz>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
petarvujovic98
approved these changes
Sep 19, 2024
Co-authored-by: Petar Vujović <petarvujovic98@gmail.com>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix for client error message handling. #376
Currently UnspecifiedFailureReason seems a easy fit for merely db storage.
I change it to error return, next I think we need refine the error msg db as we need to give clear error message to client.