Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Explorer: poll for updates from status #122

Closed
tylersmalley opened this issue Jul 25, 2023 · 1 comment · Fixed by #238
Closed

Node Explorer: poll for updates from status #122

tylersmalley opened this issue Jul 25, 2023 · 1 comment · Fixed by #238
Assignees
@tendstofortytwo
Labels
help wanted Extra attention is needed

Comments

@tylersmalley
Copy link
Contributor

We should not rely on the user clicking the refresh button and should poll at a set interval (5 second default).
@tylersmalley tylersmalley changed the title Node Explorer should poll for updates from status Node Explorer: poll for updates from status Jul 25, 2023
@tylersmalley
Copy link
Contributor Author

Easiest solution would be to pull every 5 seconds (should eventually be configurable), and compare to the existing nodes. if it differes, then call "refresh" on the NodeExplorerProvider. Because of #182, calling refresh is very heavy and we should limit the use.

@tendstofortytwo tendstofortytwo mentioned this issue Sep 26, 2023
Merged
tendstofortytwo added a commit that referenced this issue Sep 28, 2023
@tendstofortytwo
Node Explorer: poll for peer/tailnet updates (#238)
82b995e 
Fixes #122.

---------

Signed-off-by: Naman Sood <mail@nsood.in>
tylersmalley pushed a commit that referenced this issue Sep 28, 2023
@tendstofortytwo @tylersmalley
Node Explorer: poll for peer/tailnet updates (#238)
e247311 
Fixes #122.

---------

Signed-off-by: Naman Sood <mail@nsood.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tendstofortytwo tendstofortytwo

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node Explorer: poll for peer/tailnet updates tailscale-dev/vscode-tailscale
3 participants
@tylersmalley @samlinville @tendstofortytwo