Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message for expired node key #1

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

marwan-at-work
Copy link
Contributor

This PR does a couple of things:

  1. Sets the OFFLINE error when key is expired. We can potentially make it a special message.
  2. It also adds a socket path for extension development if we need it to point to a different localapi or server.

@tylersmalley
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
release-branch/v0.4

Questions ?

Please refer to the Backport tool documentation

tylersmalley pushed a commit that referenced this pull request Jun 7, 2023
* Show error message for expired node key

* Remove old booleans

* Remove unused type

(cherry picked from commit e6f39d1)
@tylersmalley tylersmalley added v0.4 Release v0.4 backport auto-backport and removed v0.4 Release v0.4 backport labels Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

💔 All backports failed

Status Branch Result
release-branch/v0.4 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.

Manual backport

To create the backport manually run:

backport --pr 1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
* Show error message for expired node key

* Remove old booleans

* Remove unused type

(cherry picked from commit e6f39d1)
@tylersmalley tylersmalley added v0.4 Release v0.4 auto-backport and removed v0.4 Release v0.4 auto-backport labels Jun 7, 2023
tylersmalley pushed a commit that referenced this pull request Jun 7, 2023
* Show error message for expired node key

* Remove old booleans

* Remove unused type

(cherry picked from commit e6f39d1)
@tylersmalley
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
release-branch/v0.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tylersmalley added a commit that referenced this pull request Jun 7, 2023
# Backport

This will backport the following commits from `main` to
`release-branch/v0.4`:
- [Show error message for expired node key
(#1)](#1)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

Co-authored-by: Marwan Sulaiman <marwan.sameer@gmail.com>
tylersmalley pushed a commit that referenced this pull request Jun 13, 2023
* Show error message for expired node key

* Remove old booleans

* Remove unused type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants