NodeExplorer: Implements Nodes list #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tsobj-file-system-provider.ts
Outdated
| Logger.info(`hostname: ${hostname}`, 'tsobj-fsp'); | ||
| Logger.info(`remotePath: ${resourcePath}`, 'tsobj-fsp'); | ||
|
|
||
| const command = `ssh ${hostname} ls -lA "${resourcePath}"`; |
There was a problem hiding this comment.
can we just run ls -ap here? it wouldn't require skipping lines or anything.
There was a problem hiding this comment.
Yeah, we can do ls -Ap. A will exclude the . and .. special entries.
src/tsobj-file-system-provider.ts
Outdated
| const type = isDirectory ? vscode.FileType.Directory : vscode.FileType.File; | ||
| files.push([name, type]); | ||
| } | ||
| resolve(files); |
There was a problem hiding this comment.
can we sort the files so that directories show up first? This is how the regular file explorer sorts the display
| vscode.TreeDragAndDropController<PeerBaseTreeItem>, | ||
| vscode.FileDecorationProvider | ||
| { | ||
| dropMimeTypes = ['text/uri-list']; // add 'application/vnd.code.tree.testViewDragAndDrop' when we have file explorer |
There was a problem hiding this comment.
I think this PR is missing this commit: 60dc7fa
At least the TypeScript part (not the Go part, since we're just shelling out to SSH)
This way we can have scp work between peers. We can also do it as a follow up PR.
There was a problem hiding this comment.
Yeah, let's do that as a follow up.
Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a Node Explorer, hidden behind a setting.