Node Explorer: Some error message improvements #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
tyler/improve-errors
branch
from
1b3107f
to
e3700f9
Compare
tylersmalley
commented
Aug 4, 2023
| @@ -316,8 +321,9 @@ | |||
| "title": "Attach VS Code" | |||
| }, | |||
| { | |||
| "command": "tailscale.openExternal", | |||
| "title": "Open External Link" | |||
| "command": "tailscale.node.openDocsLink", | |||
There was a problem hiding this comment.
I renamed it to improve the tooltip for the inline context.
tylersmalley
force-pushed
the
tyler/improve-errors
branch
from
e3700f9
to
1a95fdd
Compare
Using a Tree View Item as a button to trigger a command, which we are doing, is explitally [called out](https://code.visualstudio.com/api/ux-guidelines/views#tree-views) as a "Don't" in the UX Guidelines. Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley
force-pushed
the
tyler/improve-errors
branch
from
1a95fdd
to
0c80d9e
Compare
marwan-at-work
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Tree View Item as a button to trigger a command, which we are doing, is explicitly called out as a "Don't" in the UX Guidelines.
To adhere to this, we should use an inline context for the external docs link.
On hover, you see the following:
Tailscale not running:
Running but not logged in: