Node Explorer: accept subdirectories of ~ for root directory #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naman Sood <mail@nsood.in>
tylersmalley
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Looks like this resolves the issue of displaying the directory, but results in new files/folders not being able to be created.
I think you can resolve this by expanding the tilde after we capture homeDir with this.fsProvider.getHomeDirectory. SFTP doesn't work with a tilde, so we have to expand it when we create the root of the tree and use that going forward.
Signed-off-by: Naman Sood <mail@nsood.in>
tylersmalley
pushed a commit
that referenced
this pull request
Sep 28, 2023
Fixes #200. --------- Signed-off-by: Naman Sood <mail@nsood.in>
tylersmalley
added a commit
that referenced
this pull request
Sep 28, 2023
``` % git log --pretty=oneline v0.6.2..release-branch/v0.6 (HEAD -> release-branch/v0.6) chore(deps): update dependency @vscode/vsce to ^2.21.0 (#223) chore(deps): update dependency @types/vscode-webview to ^1.57.2 (#218) chore(deps): update dependency concurrently to ^8.2.1 (#219) chore(deps): update dependency lint-staged to ^13.3.0 (#196) tsrelay: update for 1.50 (#239) Node Explorer: prompt to add nodes to SSH config file for VSCode remotes list (#233) Node Explorer: accept subdirectories of ~ for root directory (#230) File Explorer: add configuration option to hide dotfiles (#221) package.json: Remove from testing category (#226) chore(deps): update dependency swr to ^2.2.2 (#195) chore(deps): update dependency @types/react to ^18.2.21 (#194) chore(deps): update eslint (#137) package.json: Updates the description (#215) README.md: Use lowercase "internet" (#216) ``` --------- Signed-off-by: Tyler Smalley <tyler@tailscale.com> Co-authored-by: Naman Sood <mail@nsood.in>
tylersmalley
added a commit
that referenced
this pull request
Sep 28, 2023
``` % git log --pretty=oneline v0.6.2..release-branch/v0.6 (HEAD -> release-branch/v0.6) chore(deps): update dependency @vscode/vsce to ^2.21.0 (#223) chore(deps): update dependency @types/vscode-webview to ^1.57.2 (#218) chore(deps): update dependency concurrently to ^8.2.1 (#219) chore(deps): update dependency lint-staged to ^13.3.0 (#196) tsrelay: update for 1.50 (#239) Node Explorer: prompt to add nodes to SSH config file for VSCode remotes list (#233) Node Explorer: accept subdirectories of ~ for root directory (#230) File Explorer: add configuration option to hide dotfiles (#221) package.json: Remove from testing category (#226) chore(deps): update dependency swr to ^2.2.2 (#195) chore(deps): update dependency @types/react to ^18.2.21 (#194) chore(deps): update eslint (#137) package.json: Updates the description (#215) README.md: Use lowercase "internet" (#216) ``` --------- Signed-off-by: Tyler Smalley <tyler@tailscale.com> Co-authored-by: Naman Sood <mail@nsood.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200.