Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return manual resolution when access is denied to LocalBackend #60

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

marwan-at-work
Copy link
Contributor

This PR returns an explicit json error with status 403 for when LocalBackend returns an AccessDenied error on SetServe.

The UI could then catch the error and display the command to the user as a manual resolution

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marwan-at-work marwan-at-work merged commit b946afc into main Jun 14, 2023
@marwan-at-work marwan-at-work deleted the marwan/sudo branch June 14, 2023 17:55
tylersmalley pushed a commit that referenced this pull request Jun 21, 2023
This PR returns an explicit json error with status 403 for when
LocalBackend returns an AccessDenied error on SetServe.

The UI could then catch the error and display the command to the user as
a manual resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants